This repository was archived by the owner on Aug 16, 2019. It is now read-only.
feat: change new db name to verdaccio #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanpicado
reviewed
Aug 25, 2018
src/local-database.js
Outdated
| @@ -246,7 +246,12 @@ class LocalDatabase implements IPluginStorage { | |||
| * @private | |||
| */ | |||
| _buildStoragePath(config: Config) { | |||
| return Path.join(Path.resolve(Path.dirname(config.self_path || ''), (config: any).storage, '.sinopia-db.json')); | |||
| const sinopiadbPath = Path.join(Path.resolve(Path.dirname(config.self_path || ''), (config: any).storage, '.sinopia-db.json')); | |||
There was a problem hiding this comment.
Perfect, only Path.join(Path.resolve(Path.dirname(config.self_path || ''), (config: any).storage, might be a function inside of _buildStoragePath. The code is dupe.
const buildDBPath = (name) => Path.join(Path.resolve(Path.dirname(config.self_path || ''), (config: any).storage, name));
...
const sinopiadbPath = buildDBPath('.sinopia-db.json');
...
return buildDBPath('.verdaccio-db.json');
|
You are right. I added the function inside _buildStoragePath, and used it twice, for 'sinopia-db.json' and 'verdaccio-db.json'. |
juanpicado
approved these changes
Aug 25, 2018
|
Great:) thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
Description:
Detect whether .sinopia-db.json is exist otherwise set db path to .verdaccio-db.json.