Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Dependabot Config #110

Merged
merged 3 commits into from
Nov 21, 2022

Conversation

rblaine95
Copy link
Collaborator

Dependabot recently got support for Docker Image version bumps in kubernetes manifests.

* Dependabot recently got support for Docker Image version bumps in
  kubernetes manifests
@rblaine95 rblaine95 added the enhancement New feature or request label Nov 18, 2022
@rblaine95 rblaine95 requested review from a team November 18, 2022 09:29
juanpicado
juanpicado previously approved these changes Nov 18, 2022
Copy link
Member

@juanpicado juanpicado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice !

@juanpicado juanpicado requested a review from a team November 18, 2022 11:03
@rblaine95
Copy link
Collaborator Author

rblaine95 commented Nov 18, 2022

I think it'll be a good idea to leave this PR open for a day or so.
I've cherry-picked this commit onto my master branch in my fork just to give dependabot a day to verify it works as expected.

I expect dependabot to open PRs on my side to update the actions (checkout@v2 -> checkout@v3) and bump the image version.
I hope dependabot also bumps the Chart version.

@rblaine95
Copy link
Collaborator Author

Looks like the Actions updates are working
image

@juanpicado
Copy link
Member

Awesome 👏🏻!!

@rblaine95
Copy link
Collaborator Author

rblaine95 commented Nov 19, 2022

Ah, ok, after some digging I see why it's not updating the image tag.

It looks like Dependabot parses the values.yaml file looking for image.tag, which we're not setting.
We're setting the image tag with .Chart.appVersion unless .Values.image.tag is set. 🤔

Edit: Setting the image version in values.yaml triggers Dependabot - rblaine95#7
Unfortunately, Dependabot doesn't bump the Chart version

image
image

@juanpicado
Copy link
Member

Seems related to this dependabot/dependabot-core#1744 ?

felipeplets
felipeplets previously approved these changes Nov 21, 2022
Copy link

@felipeplets felipeplets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a question. Nice contribution @rblaine95!

@juanpicado
Copy link
Member

@rblaine95 have you tried renovate instead https://docs.renovatebot.com/modules/manager/helm-values/ ?

@rblaine95
Copy link
Collaborator Author

@juanpicado haven't heard of renovate, will take a look 👍

In the meantime, I'll remove the Docker dependabot config

@rblaine95 rblaine95 dismissed stale reviews from felipeplets and juanpicado via dfd70bf November 21, 2022 08:20
Copy link

@felipeplets felipeplets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@juanpicado juanpicado merged commit bf6a428 into verdaccio:master Nov 21, 2022
@rblaine95 rblaine95 deleted the feature/depandabot-config branch November 21, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants