fix(tui): replay all logs sent to tui with forced crlf #9962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anthonyshew
approved these changes
Feb 13, 2025
chris-olszewski
deleted the
chrisolszewski/turbo-4295-properly-replay-ttynon-tty-regardless-of-tui-usage
branch
joshnuss
pushed a commit
to joshnuss/turborepo
that referenced
this pull request
Feb 15, 2025
### Description If a task is run without a TTY (e.g. in CI) the logs will be created with LF (`\n`) line endings. The TUI assumes that logs are produced hooked up to a TTY where CRLF (`\r\n`) is used to return the cursor to the first column and move to the next row (`\n` behavior in non-TTY). This PR adds a log replay method that replays logs with CRLF line endings regardless of what is in the actual file. Future PR is to refactor this to share code with the standard log replay as I didn't have time to tackle this right at this moment. ### Testing Instructions Added quick unit test to verify this swaps out LF for CRLF and is a noop if the logs already use CRLF. Manual Test: First populate the logs with a non-TTY run: ``` [0 olszewski@macbookpro] /tmp/tui-test $ turbo @repo/ui#build > /dev/null ``` Using `turbo@2.4.2`: <img width="797" alt="Screenshot 2025-02-13 at 6 24 47 PM" src="https://github.com/user-attachments/assets/45439888-0098-4bb7-92b8-65eb2789cfbf" /> Using `turbo_dev` from this PR <img width="762" alt="Screenshot 2025-02-13 at 6 26 04 PM" src="https://github.com/user-attachments/assets/bd00c5dd-ebd8-41eb-9bd8-4f597925676f" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a task is run without a TTY (e.g. in CI) the logs will be created with LF (
\n) line endings. The TUI assumes that logs are produced hooked up to a TTY where CRLF (\r\n) is used to return the cursor to the first column and move to the next row (\nbehavior in non-TTY).This PR adds a log replay method that replays logs with CRLF line endings regardless of what is in the actual file.
Future PR is to refactor this to share code with the standard log replay as I didn't have time to tackle this right at this moment.
Testing Instructions
Added quick unit test to verify this swaps out LF for CRLF and is a noop if the logs already use CRLF.
Manual Test:
First populate the logs with a non-TTY run:
Using
turbo@2.4.2:Using
turbo_devfrom this PR