fix(microfrontends): fix handling of unsupported version #9883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tknickman
approved these changes
Feb 3, 2025
chris-olszewski
deleted the
chrisolszewski/turbo-4424-investigate-turbo24-upgrade-failure-with-microfrontendsjson
branch
chris-olszewski
added a commit
that referenced
this pull request
Feb 4, 2025
### Description Make it so any invalid MFE configs no longer fail the process. We had this behavior previously for unsupported versions, but it broke somewhere along the lines where we were throwing `InvalidVersions` instead. ### Testing Instructions Added unit test. Quick manual verification: ``` [0 olszewski@chriss-mbp] /Users/olszewski/code/vapi $ turbo_dev --skip-infer build --dry > /dev/null turbo 2.4.0 WARNING Ignoring control-plane-default: Unsupported microfrontends configuration version: 2. Supported versions: ["1"] ```
chris-olszewski
added a commit
that referenced
this pull request
Feb 12, 2025
### Description TSIA We were requiring the version to exist in `VersionOnly` schema so we could decide which config schema to use. I'm assuming I broke this in #9883, but it's not immediately obvious to me how. ### Testing Instructions Added failing unit test for versionless `Config::load_from_dir` call
chris-olszewski
added a commit
that referenced
this pull request
Feb 13, 2025
### Description TSIA We were requiring the version to exist in `VersionOnly` schema so we could decide which config schema to use. I'm assuming I broke this in #9883, but it's not immediately obvious to me how. ### Testing Instructions Added failing unit test for versionless `Config::load_from_dir` call
joshnuss
pushed a commit
to joshnuss/turborepo
that referenced
this pull request
Feb 15, 2025
### Description TSIA We were requiring the version to exist in `VersionOnly` schema so we could decide which config schema to use. I'm assuming I broke this in vercel#9883, but it's not immediately obvious to me how. ### Testing Instructions Added failing unit test for versionless `Config::load_from_dir` call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make it so any invalid MFE configs no longer fail the process.
We had this behavior previously for unsupported versions, but it broke somewhere along the lines where we were throwing
InvalidVersionsinstead.Testing Instructions
Added unit test. Quick manual verification: