feat(trace): more trace fixes #9474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olve TypeScript type definition package if package doesn't exist
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
tknickman
approved these changes
Nov 20, 2024
chris-olszewski
approved these changes
Nov 20, 2024
| @@ -316,7 +328,14 @@ impl Tracer { | |||
| .with_force_extension(EnforceExtension::Disabled) | |||
| .with_extension(".ts") | |||
| .with_extension(".tsx") | |||
| .with_module(self.cwd.join_component("node_modules").to_string()) | |||
There was a problem hiding this comment.
Confirming we no longer want to consider working directory's node_modules
There was a problem hiding this comment.
yeah turns out this is built into oxc-resolver so we don't need to do this
| @@ -5,6 +5,7 @@ | |||
| "maybefails": "exit 4" | |||
| }, | |||
| "dependencies": { | |||
| "utils": "*" | |||
| "utils": "*", | |||
| "@types/d3-scale": "^4.0.2" | |||
There was a problem hiding this comment.
Can we make this an exact version to prevent this getting bumped and behaving unexpectedly.
Suggested change
| "@types/d3-scale": "^4.0.2" | |
| "@types/d3-scale": "4.0.2" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A couple small fixes for tracing:
moduleis non-standard but common)@types/<package>if<package>fails to resolveTesting Instructions
Added tests for new extensions, for module field, and for importing types from
foothat really come from@types/foo