Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(linting): implement ESLint flat config compatibility for eslint-plugin-turbo #9426

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

jeremy-code
Copy link
Contributor

Description

  • Add "flat/recommended" config to eslint-plugin-turbo
  • Add meta property to plugin
  • Update README.md accordingly with information on using flat config
  • Add tests for flat config in __tests__/cwdFlat.test.ts

Testing Instructions

Run the following command:

pnpm run test --filter=eslint-plugin-turbo

See #8606

@jeremy-code jeremy-code requested a review from a team as a code owner November 12, 2024 18:41
@turbo-orchestrator turbo-orchestrator bot added needs: triage New issues get this label. Remove it after triage owned-by: turborepo pkg: turbo-eslint eslint-config-turbo and eslint-plugin-turbo labels Nov 12, 2024
Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 8:35pm
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 8:35pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 8:35pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 8:35pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 8:35pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 8:35pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 8:35pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 8:35pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 8:35pm

Copy link

vercel bot commented Nov 12, 2024

@jeremy-code is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@jeremy-code
Copy link
Contributor Author

@anthonyshew This branch should be good, ran tests/lint/prettier.

Copy link

socket-security bot commented Nov 12, 2024

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@types/eslint@8.4.6

View full report↗︎

@jeremy-code jeremy-code changed the title chore(linting): implement ESLint flat config compatibility for `eslin… chore(linting): implement ESLint flat config compatibility for eslint-plugin-turbo Nov 12, 2024
…t-plugin-turbo`

- Add "flat/recommended" config to `eslint-plugin-turbo`
- Add `meta` property to plugin
- Update README.md accordingly with information on using flat config
- Add tests for flat config in `__tests__/cwdFlat.test.ts`
@jeremy-code
Copy link
Contributor Author

(That was just a rebase to catch up with 1 commit in main -- no lock file changes or anything)

@ijjk
Copy link
Member

ijjk commented Nov 12, 2024

Allow CI Workflow Run

  • approve CI run for commit: ac39f63

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you so much for being patient with us taking much too long to get back to you on this. Very excited for this - and I know many community members are as well!

@anthonyshew anthonyshew merged commit f4be2da into vercel:main Nov 14, 2024
42 checks passed
@anthonyshew
Copy link
Contributor

So glad to have merged this. Thank you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: triage New issues get this label. Remove it after triage pkg: turbo-eslint eslint-config-turbo and eslint-plugin-turbo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants