Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Detect WSL in turbo info. #9416

Merged
merged 2 commits into from
Nov 8, 2024
Merged

feat: Detect WSL in turbo info. #9416

merged 2 commits into from
Nov 8, 2024

Conversation

anthonyshew
Copy link
Contributor

@anthonyshew anthonyshew commented Nov 8, 2024

Description

We have had cases in the past where it would be nice to know if the user is using WSL. This adds best effort detection for printing out if you're using WSL.

Note that this isn't a 100% solution, according to this superuser answer. But, if you're doing something like is listed in the caveats...That's an extreme edge case.

Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 5:22pm
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 5:22pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 5:22pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 5:22pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 5:22pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 5:22pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 5:22pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 5:22pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 5:22pm

@anthonyshew anthonyshew changed the title feat: Detect WSL in turbo info. feat: Detect WSL in turbo info. Nov 8, 2024
Copy link
Member

@chris-olszewski chris-olszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worst case if is_wsl returns a faulty answer we have an additional back and forth with a user.

@anthonyshew anthonyshew enabled auto-merge (squash) November 8, 2024 17:30
@anthonyshew anthonyshew merged commit deb9ae1 into main Nov 8, 2024
39 checks passed
@anthonyshew anthonyshew deleted the shew-3c45d branch November 8, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants