Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for windows x yarn users #93

Merged
merged 8 commits into from
Dec 4, 2021
Merged

Conversation

jaredpalmer
Copy link
Contributor

@jaredpalmer jaredpalmer commented Dec 3, 2021

  • Move from path.Join to filepath.Join everywhere (TIL / yeesh)
  • There is currently still a bug in parsing yarn.lock on Windows machines so this falls back to full lockfile hashing (w/yarn) (like npm and pnpm). This will mean windows x yarn users will have different hashes than unix x yarn users, but this at least moves us from p0 to p1 problem.
  • Fix git.ChangedFiles
  • Update e2e tests for windows

#techdebt

@jaredpalmer jaredpalmer added the kind: bug Something isn't working label Dec 3, 2021
@vercel
Copy link

vercel bot commented Dec 3, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/turbo-site/r3uV6CNpVjvKYeGnM34KHxSJDT2m
✅ Preview: https://turbo-site-git-hack-fix-windows.vercel.sh

@jaredpalmer jaredpalmer merged commit e04ef17 into main Dec 4, 2021
@jaredpalmer jaredpalmer deleted the hack-fix-windows branch December 4, 2021 23:01
sokra added a commit that referenced this pull request Oct 25, 2022
Follow sourceMappingURL references
sokra pushed a commit that referenced this pull request Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant