fix: #909 - turbo run exit code always 0 #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ThibautMarechal is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vercel/turbo-site/EPj2SoTpBa1eeV2YmvJsswZx8JmC |
|
Marking this as ready for review, as I think this fixes a regression. |
gsoltis
approved these changes
Mar 21, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Mar 23, 2022
) Fixes #912 In this PR: * Stop removing unreferenced packages from the package dependency graph before building the task graph. * Remove the implied `--include-dependencies` if `--scope` and `--since` are both set. It should no longer be necessary. * Remove the test for `--scope` and `--since` implying `--include-dependencies` * Add a new scheduler test that mimics the way `run` now behaves. * Add a debugging profile for doing a dry run against the kitchen sink example. Future work includes being able to write a test in `run_test.go` to get the whole end-to-end graph build, but we don't quite have the infrastructure for that yet (also required for follow-on work to #911) Note that this is technically a breaking change. Previously, if `a` depends on `b`, and the `"test"` task depends on `"^build"` the following would be true: * `turbo run test --scope=a` would test `a` but not build `b` * `turbo run test --scope=a --include-dependencies` would build `b` and test `a` *AND* `b`. With this change, `turbo run test --scope=a` will now build `b` and test `a`. The addition of tasks running for unselected packages is new. While this seems like more work being done, in practice I expect users to be able to move from the second example above to the first, ultimately resulting in less work being done: `b#test` will no longer need to run to get `a#test` to run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will try to add a test for tomorrow, but I'm not a Go dev, so I might need some help at some point 🙂