Switch task graph edges to direct dependencies #869
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change in this PR switches the task graph construction to add edges only between direct dependencies, rather than the entire ancestor subtree.
As an example, say
a
depends onb
,b
depends onc
. Ifb#build
depends onc#some-task
, and a#builddepends on
^build`.Currently, running
a#build
will doc#some-task
,c#build
,b#build
, anda#build
.But, we don't need
c#build
. We just needc#some-task
, since that's whatb#build
depends on, anda
doesn't really know anything aboutc
directly, just viab
. So, we instead just draw an edge to direct dependencies, and then let them sort out their own dependencies.For a large example, here are before and after graphs for running
turbo run build
inexamples/kitchen-sink
:Before:

After:

Also get rid of an unused field,
taskDeps
, onScheduler
.