Remove dependencies on context methods / functions #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vercel/turbo-site/GF29pFipW88vTP3mpEE196K3iFX9 |
gsoltis
changed the title
jaredpalmer
approved these changes
Mar 3, 2022
| @@ -28,6 +28,7 @@ const GLOBAL_CACHE_KEY = "snozzberries" | |||
|
|
|||
| // Context of the CLI | |||
| type Context struct { | |||
| RootPackageInfo *fs.PackageJSON // TODO(gsoltis): should this be included in PackageInfos? | |||
There was a problem hiding this comment.
I think eventually this will be. Big feature request is the ability to be able to run tasks from root. I wonder if this is as easy as just adding root to to package infos. and then removing the special resolution logic, but keeping the special edge connecting logic?
We also will need inputs:[] or something to restrict what should be hashed, but I'll spec that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing to remove code dependencies on the
internal/contextpackage so that we can possibly calculate the values remotely / asynchronously.getTargetsFromArgumentsfromcontexttorun, the only place where it is called.prunereuses the work done resolving global dependencies during context creation. This both reduces the dependency on a method oncontextas well as avoids doing duplicate work.contextmethods private so that we don't accidentally rely on them elsewhere.