-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(yarn-pnp): adding support for turbo run w/ yarn pnp #797
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vercel/turbo-site/8gFsXo25kYxmztMtL4ke9qB7xUJG |
b03c459
to
c9f4da5
Compare
c9f4da5
to
5e6f8a5
Compare
5e6f8a5
to
8fbfdd1
Compare
I got a CI test failure on windows-latest, re-running seems to have 'fixed' it. The test failure happens for me locally as well, but also shows up in |
25e5e19
to
b308178
Compare
More specifically this removes the general check for yarn pnp and moves it into the prune command instead as this is the part that likely has remaining issues with pnp.
9561589
to
c0f5ada
Compare
@jaredpalmer / @gsoltis is there any additional testing that needs to be done to be able to move this PR forward? |
@thebanjomatic is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
@gsoltis Is there a way we can get a canary release from this PR so that other consumers with yarn 2 PnP repos can test and validate this change? I have verified that its working in my own repos at this point, but I'm given there wasn't any actual code change made on my part to enable this functionality, I can understand there may be some uncertainty around this PR. |
Regarding #693 (comment) I believe this at least partially addresses Issue: #693, but the scope of the issue is unclear.
More specifically this removes the general check for yarn pnp and moves it into the prune command instead as this is the part that likely has remaining issues with pnp since nothing else that I'm aware of needs to know about
node_modules
.This PR builds off of #795, as otherwise you can't even run turbo to be able to hit the previous nodeLinker checks.
Let me know if you would like me to change things around so that it is more explicitly enabling for the run task as opposed to enabling for all but prune.