Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bounded parallelization when saving cache #723

Merged
merged 17 commits into from
Mar 2, 2022
Merged

fix: bounded parallelization when saving cache #723

merged 17 commits into from
Mar 2, 2022

Conversation

glesperance
Copy link
Contributor

@glesperance glesperance commented Feb 11, 2022 •
edited
Loading

Fix for #711 (discussion #709).

Bounded cache saving parallelization to runtime.NumCPU() which now gives us the maximum number of effective threads while staying under the OS limit of max processes count.

Cheers 🎉

@vercel
Copy link

vercel bot commented Feb 11, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/turbo-site/6KYpyJf7wDUM1jM4BhPZqvXyByAh
✅ Preview: https://turbo-site-git-fork-glesperance-fix-runtime-too-many-threads.vercel.sh

[Deployment for 3a4379d failed]

@glesperance glesperance force-pushed the fix/runtime-too-many-threads branch from 7860a93 to 53e27c5 Compare February 11, 2022 05:22
@glesperance glesperance requested a review from gsoltis February 11, 2022 15:33
@glesperance glesperance force-pushed the fix/runtime-too-many-threads branch from 401c8fa to f804c14 Compare February 11, 2022 15:33
gsoltis
gsoltis suggested changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@gsoltis gsoltis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a much better approach!

I think the next step is to figure out how to thread a configuration value through to this point so that it can be customized.

@glesperance glesperance force-pushed the fix/runtime-too-many-threads branch from 76fa406 to 7a148dd Compare February 11, 2022 23:41
@glesperance glesperance requested a review from gsoltis February 11, 2022 23:42
@glesperance
Copy link
Contributor Author

@gsoltis any chance we can get this merged without the configurable option? I understand a parameter would be good, but I feel it's best we fix the issue first.

@jaredpalmer
Copy link
Contributor

Cutting now

@jaredpalmer jaredpalmer changed the title Fix(cli): bounded parallelization when saving cache fix(cli): bounded parallelization when saving cache Feb 25, 2022
@jaredpalmer jaredpalmer changed the title fix(cli): bounded parallelization when saving cache fix: bounded parallelization when saving cache Feb 25, 2022
@kodiakhq kodiakhq bot merged commit 7a8bd0d into vercel:main Mar 2, 2022
@glesperance glesperance deleted the fix/runtime-too-many-threads branch March 3, 2022 18:28
@fizx fizx mentioned this pull request Mar 29, 2022
Closed
@tknickman tknickman mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsoltis gsoltis gsoltis approved these changes

@jaredpalmer jaredpalmer jaredpalmer approved these changes

@gaspar09 gaspar09 Awaiting requested review from gaspar09

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glesperance @jaredpalmer @gsoltis