Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: conditionally set arch when installing hyperfine #584

Conversation

virtuoushub
Copy link
Contributor

@virtuoushub virtuoushub commented Jan 21, 2022

When running a dev container on a non arm64/Apple Silicon machine I got the following:

...
#7 0.924 2022-01-21 21:52:15 (7.02 MB/s) - 'hyperfine_1.12.0_arm64.deb' saved [553772/553772]
#7 0.924 
#7 0.938 dpkg: error processing archive hyperfine_1.12.0_arm64.deb (--install):
#7 0.938  package architecture (arm64) does not match system (amd64)
#7 0.944 Errors were encountered while pr
[2022-01-21T21:52:15.716Z] ocessing:
#7 0.944  hyperfine_1.12.0_arm64.deb
...

This PR will account for some architectures other than arm64 (e.g. amd64)

See also: https://stackoverflow.com/a/58222507

note: for architectures other than arm64, amd64, armhf or i686 the install will still fail, so maybe we want a smarter check here.

@vercel
Copy link

vercel bot commented Jan 21, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/turbo-site/4WVVFof83mTUuyLvc6NENpfTcjxT
✅ Preview: https://turbo-site-git-fork-virtuoushub-fix-allow-installing-hyp-d7b7ec.vercel.sh

@jaredpalmer jaredpalmer merged commit 0545975 into vercel:main Jan 21, 2022
@virtuoushub virtuoushub deleted the fix/allow-installing-hyperfine-on-non-arm64-arch branch January 21, 2022 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants