fix: error when workspaces are not defined #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vercel/turbo-site/8sdWJNJEGvtCJHZyGxVVub2RfHPn |
|
@jaredpalmer is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
jaredpalmer
changed the title
jaredpalmer
approved these changes
Jan 10, 2022
jaredpalmer
added
the
pr: automerge
sokra
pushed a commit
that referenced
this pull request
Oct 25, 2022
1. Takes advantage of `HashSet`s instead of `Vec`s for collections, since a TaskId could be seen multiple times 2. Avoids several `CountHashSet`->`Vec`->`CountHashSet` round trips during recursive `read_collectibles` 3. Moves taking collectibles into the backend, so that it can be performed before the state lock is released. This alone doesn't solve my issue with logging. No matter what changes I've tried to the backend (`children` scopes crawling, collating into a `CountHashSet` during reads (because items could be very negative but still have a single positive elsewhere stack)), I constantly see the same message over and over. I now think it's because the `turbopack-dev-server` is spawning new root tasks everytime it receives a network request. That root task is completely divorced from prior executions, so every time we've un-emitted, it's just re-emitted during the computation of the new root task's subtasks. I think we need to invert the network-handler -> turbo-tasks nesting to be turbo-tasks -> network-handler, with a persistent root task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workspaces are required for turborepo to work, but lack of them results in unfriendly error message that does not explain that. The PR may need some changes, that's just a quick fix you could use.