-
Notifications
You must be signed in to change notification settings - Fork 27.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed staticMarkup option from docs. #722
Comments
@ehtb for the AMP page, I assume you could use our custom document support as well. |
See vercel#722 as well, but I can imagine more use cases.
@arunoda Thanks for the tip, that sounds very interesting as well! I've created a pr which allows overriding the default render options per render request ( This allows for instance:
|
I added |
Closing in favor of the AMP example. Please re-open if needed ❤️ |
I would like to reopen this. Here is my pull request #3589 |
684cc25 reverted the documented feature to render static HTML (
staticMarkup
) without any additional info.Does this mean it will be deprecated in the future? The reason I am asking is because I want to render an AMP page and this could be the right direction. Although this is a setting that can better be handled on the page level:
app.renderToHTML(req, res, pagePath, queryParams, {staticMarkup:true})
.Perhaps if not, this could be added as an example (happy to do that), just because the setting is a bit hidden.
The text was updated successfully, but these errors were encountered: