-
Notifications
You must be signed in to change notification settings - Fork 27.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add displayName to error page(s) #6026
Comments
Sounds good to me 🤔 |
@timneutkens Cool, any preference on what that should be? |
I guess |
@timneutkens Forgive me if I'm being naïve but is it as simple as #6029? There isn't any documentation on Also, I tried to run The tests seem to be failing on CI but it looks like a registry thing. |
Looks fine to me! |
Feature request
Is your feature request related to a problem? Please describe.
Recently in next-i18next, we implemented some console warnings to improve DX. If a page-level component does not return
namespacesRequired
inpageProps
, we pass a warning and print that component'sdisplayName
to be helpful. This caused me to realise that the _error.js page does not have adisplayName
.Describe the solution you'd like
Add a sensible
displayName
to the_error.js
page so that tools built on top of NextJs can make sense of what it is.I am happy to quickly submit a PR for this and hopefully see it merged and released ASAP! If there is good reason for
_error.js
to not have adisplayName
, please do let me know - I searched through the issues and found nothing.The text was updated successfully, but these errors were encountered: