Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark more errors as runner system failures #32

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

tejassharma96
Copy link
Contributor

Pull Request

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Build related changes
  • Documentation content changes
  • Other: (describe here)

Proposed Change

Issue Number: #28

Update several more errors that occur while starting up the VM as runner system failures, rather than reporting them as script failures

Breaking Change?

Maybe? Depends on how/whether people have set up alerting on runner system failures for their anka executors, but they will see more of those with this change. It doesn't break any functionality, so imo this is not a breaking change.

Checklist

Please validate that your PR fulfills the following requirements:

  • I have branched from the default repo branch (can be master, main, or release/vX.X)
  • I have checked that a similar PR does not exist or has been rejected in the past
  • PR changes are specific to a feature or bug
  • No style/format/cosmetic changes included
  • I have used existing style and naming patterns in my changes
  • Tests for the changes have been added/updated (if relevant)
  • Built/compiled and tested locally
  • Docs have been added/updated (if relevant)
  • I have squashed my changes into a single commit

Additional Information

@github-service-user-veertu
Copy link
Collaborator

Can one of the admins verify this patch?

@NorseGaud
Copy link
Member

github-service-user-veertu run build

@tejassharma96
Copy link
Contributor Author

tejassharma96 commented Oct 18, 2024

FYI despite my initial thought in slack that everything in prepare.go should be a runner system error, I left the check for the template uuid/name verification as script failures, since really that indicates that there is something wrong with the gitlab ci configuration rather than something going wrong in the runner. I'd be fine updating those to be runner system failures too though, I am not strongly opinionated (for specifically that case, I am opinionated about these other ones 😅)

@NorseGaud NorseGaud merged commit aeba20d into veertuinc:main Oct 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants