Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(buffers): Upgrade to tokio channels #5868

Merged
merged 5 commits into from
Jan 5, 2021
Merged

Conversation

ktff
Copy link
Contributor

@ktff ktff commented Jan 5, 2021

Closes #5776

Besides upgrading buffers to tokio channels, upgrades the rest of buffer interface to futures03. With that, disk buffers can be upgraded to futures03 independently.

ktff added 3 commits January 5, 2021 19:22
Signed-off-by: ktf <krunotf@gmail.com>
Signed-off-by: ktf <krunotf@gmail.com>
Signed-off-by: ktf <krunotf@gmail.com>
@ktff ktff added domain: buffers Anything related to Vector's memory/disk buffers domain: deps Anything related to Vector's dependencies labels Jan 5, 2021
@ktff ktff self-assigned this Jan 5, 2021
@ktff ktff requested a review from lukesteensen as a code owner January 5, 2021 19:45
Copy link
Member

@lukesteensen lukesteensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are some imports to clean up, but otherwise, this looks good!

ktff added 2 commits January 5, 2021 21:31
Signed-off-by: ktf <krunotf@gmail.com>
Signed-off-by: ktf <krunotf@gmail.com>
@binarylogic binarylogic merged commit 43325a3 into master Jan 5, 2021
@binarylogic binarylogic deleted the ktff/buffer_update branch January 5, 2021 22:22
@ktff ktff mentioned this pull request Jan 29, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: buffers Anything related to Vector's memory/disk buffers domain: deps Anything related to Vector's dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade BufferInputCloner to tokio channels
3 participants