Skip to content

Commit

Permalink
sagemathgh-37810: build/pkgs/gambit: Remove
Browse files Browse the repository at this point in the history
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Removing this broken experimental package, as proposed in 2020.
- Closes sagemath#30156

Also removing the module providing outdated "standalone instructions" to
use Gambit.

Keeping the various references to Gambit tagged with `# optional -
gambit`. This will be updated in the follow-up PR"
- sagemath#37809


The motivation for opening this PR to remove `gambit` now (2024) is that
it removes a remaining use of the function `sdh_setup_bdist_wheel` (the
old gambit Python package could not be installed using pip). This a step
for the modernization of the build frontend for Python packages in the
Sage distribution:
- sagemath#35618

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37810
Reported by: Matthias Köppe
Reviewer(s): John H. Palmieri
  • Loading branch information
Release Manager committed Apr 28, 2024
2 parents 48ed393 + 7f354a7 commit 1ccd8bd
Show file tree
Hide file tree
Showing 13 changed files with 1 addition and 223 deletions.
30 changes: 0 additions & 30 deletions build/pkgs/gambit/SPKG.rst

This file was deleted.

4 changes: 0 additions & 4 deletions build/pkgs/gambit/checksums.ini

This file was deleted.

4 changes: 0 additions & 4 deletions build/pkgs/gambit/dependencies

This file was deleted.

1 change: 0 additions & 1 deletion build/pkgs/gambit/distros/homebrew.txt

This file was deleted.

1 change: 0 additions & 1 deletion build/pkgs/gambit/distros/repology.txt

This file was deleted.

Empty file removed build/pkgs/gambit/math
Empty file.
1 change: 0 additions & 1 deletion build/pkgs/gambit/package-version.txt

This file was deleted.

This file was deleted.

15 changes: 0 additions & 15 deletions build/pkgs/gambit/spkg-install.in

This file was deleted.

1 change: 0 additions & 1 deletion build/pkgs/gambit/type

This file was deleted.

1 change: 0 additions & 1 deletion src/doc/en/reference/game_theory/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ Game Theory
sage/game_theory/matching_game
sage/game_theory/normal_form_game
sage/game_theory/catalog_normal_form_games
sage/game_theory/gambit_docs
sage/game_theory/parser

.. include:: ../footer.txt
139 changes: 0 additions & 139 deletions src/sage/game_theory/gambit_docs.py

This file was deleted.

3 changes: 1 addition & 2 deletions src/sage/game_theory/normal_form_game.py
Original file line number Diff line number Diff line change
Expand Up @@ -236,8 +236,7 @@
`Gambit <http://gambit.sourceforge.net/>`_ [Gambit]_. At present this is
the only gambit algorithm available in sage but further development will
hope to implement more algorithms
(in particular for games with more than 2 players). To install it,
type ``sage -i gambit`` in the shell.
(in particular for games with more than 2 players).
* ``'enumeration'``: Support enumeration for 2 player games. This
algorithm is hard coded in Sage and checks through all potential
Expand Down

0 comments on commit 1ccd8bd

Please sign in to comment.