fix(rln): review and refine utility functions in rln #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinhtc27
changed the title
Benchmark for 3f2009cClick to view benchmark
|
Benchmark for 1bd7e8dClick to view benchmark
|
Benchmark for 3f2009cClick to view benchmark
|
Benchmark for 3f2009cClick to view benchmark
|
Benchmark for 1bd7e8dClick to view benchmark
|
Benchmark for 1bd7e8dClick to view benchmark
|
…or handling big-endian
Benchmark for 1cd0004Click to view benchmark
|
Benchmark for 1cd0004Click to view benchmark
|
Benchmark for 1cd0004Click to view benchmark
|
Benchmark for 1820eadClick to view benchmark
|
Benchmark for 1820eadClick to view benchmark
|
Benchmark for 1820eadClick to view benchmark
|
Benchmark for c388464Click to view benchmark
|
Benchmark for c388464Click to view benchmark
|
Benchmark for c388464Click to view benchmark
|
…r and optimize functions in utils.rs
Benchmark for 1b8f7e6Click to view benchmark
|
Benchmark for 1b8f7e6Click to view benchmark
|
Benchmark for 1b8f7e6Click to view benchmark
|
seemenkina
reviewed
Mar 6, 2025
|
|
||
| // We store each element | ||
| input.iter().for_each(|el| bytes.extend(fr_to_bytes_le(el))); | ||
| let mut bytes = Vec::with_capacity(8 + input.len() * fr_byte_size()); |
There was a problem hiding this comment.
could you please add comment why such size. Just for code readability in the future
|
|
||
| Ok(bytes) | ||
| } | ||
| let mut bytes = Vec::with_capacity(8 + input.len()); |
| pub fn serialize_witness(rln_witness: &RLNWitnessInput) -> Result<Vec<u8>> { | ||
| message_id_range_check(&rln_witness.message_id, &rln_witness.user_message_limit)?; | ||
|
|
||
| let mut serialized: Vec<u8> = Vec::new(); | ||
| let mut serialized: Vec<u8> = Vec::with_capacity( | ||
| fr_byte_size() * (5 + rln_witness.path_elements.len()) |
There was a problem hiding this comment.
Also good idea to describe how we calculate length
Benchmark for a6114eeClick to view benchmark
|
Benchmark for a6114eeClick to view benchmark
|
Benchmark for a6114eeClick to view benchmark
|
seemenkina
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review and refine utility functions to resolve #279: