--filter argument for split
#1681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add --filter as parameter
- carry filter parameter within `Settings`
- add `FilterWriter` to expose the stdin of a shell process
conveniently as "child process that can be written to" (the process
dies when the writer dies)
only unix for now... need to re-write for windows (is sed even available?)
the command needs not to be quoted here. Test was failing because of failing command, although it should've failed earlier (around `succeeds()`)
sylvestre
requested changes
Jan 6, 2021
all characters _in the line_ are changed to 'i'. Newline characters remain unchanged.
fix typo suggested in code review Co-authored-by: Sylvestre Ledru <sledru@mozilla.com>
sylvestre
reviewed
Jan 7, 2021
sylvestre
reviewed
Jan 7, 2021
|
still missing windows tests and a test with a failed command |
|
I guess you noticed that Windows is failing |
this uses the TYPE command that somewhat behaves like GNU's `cat`
also, don't use `cat` when running tests in windows
trying out a different "cat for windows" command.
|
well, right now I'm confused on how to write Is it |
|
OH MY DAYS Handling I'll change this to a "non-windows"-only feature, then. |
sylvestre
reviewed
Jan 16, 2021
Co-authored-by: Sylvestre Ledru <sledru@mozilla.com>
- use `show_error!` instead of `crash!` - cfg-guard code not used in windows builds (remove warnings of unused code)
It was not my intention to modify or to stage this file
sylvestre
reviewed
Jan 17, 2021
src/uu/split/src/split.rs
Outdated
| } | ||
| } | ||
| } | ||
| #[cfg(unix)] |
There was a problem hiding this comment.
this is a lot of "cfg(unix)"
what about moving that into a specific platform file?
like
https://github.com/uutils/coreutils/tree/master/src/uu/tail/src/platform/
There was a problem hiding this comment.
sure, no problem
sylvestre
reviewed
Jan 17, 2021
Co-authored-by: Sylvestre Ledru <sledru@mozilla.com>
sylvestre
reviewed
Jan 18, 2021
|
Well done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be able to pass the bytes and filename to a child shell process.