Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests using npm pack #424

Closed
ctavan opened this issue Apr 28, 2020 · 0 comments · Fixed by #425
Closed

Add tests using npm pack #424

ctavan opened this issue Apr 28, 2020 · 0 comments · Fixed by #425

Comments

@ctavan
Copy link
Member

ctavan commented Apr 28, 2020 •
edited
Loading

Add a test using npm pack, see

This was brought up in #423 (comment)
ctavan added a commit that referenced this issue Apr 28, 2020
@ctavan
test: test imports with npm package contents
d771763 
Especially for publishing CommonJS/ESM/Browser dual packages a lot can
go wrong in the actual build and release step, see:
https://medium.com/javascript-in-plain-english/is-promise-post-mortem-cab807f18dcc

In order to catch regressions with respect to the supported ways of
importing this library it makes sense to test this using `npm pack`.

Fixes #424
@ctavan ctavan mentioned this issue Apr 28, 2020
Merged
ctavan added a commit that referenced this issue Apr 29, 2020
@ctavan
test: test imports with npm package contents
3ec8896 
Especially for publishing CommonJS/ESM/Browser dual packages a lot can
go wrong in the actual build and release step, see:
https://medium.com/javascript-in-plain-english/is-promise-post-mortem-cab807f18dcc

In order to catch regressions with respect to the supported ways of
importing this library it makes sense to test this using `npm pack`.

Fixes #424
ctavan added a commit that referenced this issue Apr 29, 2020
@ctavan
test: test imports with npm package contents
0912b9b 
Especially for publishing CommonJS/ESM/Browser dual packages a lot can
go wrong in the actual build and release step, see:
https://medium.com/javascript-in-plain-english/is-promise-post-mortem-cab807f18dcc

In order to catch regressions with respect to the supported ways of
importing this library it makes sense to test this using `npm pack`.

Fixes #424
ctavan added a commit that referenced this issue Apr 29, 2020
@ctavan
test: test imports with npm package contents (#425)
57d7597 
* test: test imports with npm package contents

Especially for publishing CommonJS/ESM/Browser dual packages a lot can
go wrong in the actual build and release step, see:
https://medium.com/javascript-in-plain-english/is-promise-post-mortem-cab807f18dcc

In order to catch regressions with respect to the supported ways of
importing this library it makes sense to test this using `npm pack`.

Fixes #424

* chore: ignore *.tgz files

* build: run build as prepack command

This simplifies using npm pack in CI tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: test imports with npm package contents uuidjs/uuid
1 participant
@ctavan