-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use stable rust toolchain in version bump workflow #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
===========================================
+ Coverage 60.24% 81.36% +21.11%
===========================================
Files 4 4
Lines 161 161
===========================================
+ Hits 97 131 +34
+ Misses 64 30 -34
|
- Add comprehensive tests for template context validation - Add tests for error display and conversions - Expand CLI command parsing and execution tests - Add async template generation tests - Improve overall test coverage to 84.81%
Fix clippy::needless-borrows-for-generic-args warnings by removing unnecessary borrows when calling try_parse_from in test cases.
Split long array literals into multiple lines to improve readability and match rustfmt's preferred style.
- Add .rustfmt.toml with stable-only features - Add clippy.toml to match CI settings - Update code formatting to match new configuration
The clippy configuration should be passed via RUSTFLAGS in CI instead of using a configuration file.
Add comprehensive contributing guidelines including: - Rust toolchain requirements - Code style and linting configuration - Development workflow - CI/CD configuration details
- Add clear ALWAYS/NEVER directives for AI assistants - Standardize formatting and linting requirements - Add explicit rules for development, templates, and testing
c800c25
to
a8a78a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the version bump workflow by using a stable Rust toolchain instead of relying on the RUST_VERSION environment variable.