Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use stable rust toolchain in version bump workflow #5

Merged
merged 10 commits into from
Jan 31, 2025

Conversation

jamesbrink
Copy link
Member

This PR fixes the version bump workflow by using a stable Rust toolchain instead of relying on the RUST_VERSION environment variable.

@jamesbrink jamesbrink added release Triggers version bump workflow patch Patch version bump (bug fixes) labels Jan 31, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.36%. Comparing base (b3af1e0) to head (a8a78a4).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main       #5       +/-   ##
===========================================
+ Coverage   60.24%   81.36%   +21.11%     
===========================================
  Files           4        4               
  Lines         161      161               
===========================================
+ Hits           97      131       +34     
+ Misses         64       30       -34     
Files with missing lines Coverage Δ
src/cli/mod.rs 53.65% <ø> (+53.65%) ⬆️
src/error.rs 83.33% <ø> (+66.66%) ⬆️

Test User and others added 8 commits January 30, 2025 23:40
- Add comprehensive tests for template context validation
- Add tests for error display and conversions
- Expand CLI command parsing and execution tests
- Add async template generation tests
- Improve overall test coverage to 84.81%
Fix clippy::needless-borrows-for-generic-args warnings by removing unnecessary
borrows when calling try_parse_from in test cases.
Split long array literals into multiple lines to improve readability and
match rustfmt's preferred style.
- Add .rustfmt.toml with stable-only features
- Add clippy.toml to match CI settings
- Update code formatting to match new configuration
The clippy configuration should be passed via RUSTFLAGS in CI instead of using
a configuration file.
Add comprehensive contributing guidelines including:
- Rust toolchain requirements
- Code style and linting configuration
- Development workflow
- CI/CD configuration details
- Add clear ALWAYS/NEVER directives for AI assistants
- Standardize formatting and linting requirements
- Add explicit rules for development, templates, and testing
@jamesbrink jamesbrink force-pushed the fix/version-bump-workflow branch from c800c25 to a8a78a4 Compare January 31, 2025 07:18
@jamesbrink jamesbrink merged commit e84a77f into main Jan 31, 2025
12 checks passed
@jamesbrink jamesbrink deleted the fix/version-bump-workflow branch January 31, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Patch version bump (bug fixes) release Triggers version bump workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant