9742 Recent Messages: Update w/ Trial Session Info #2917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mrinsin
commented
Dec 19, 2022
mrinsin
commented
…s receive messages with trial information on them
29 tasks
rosiehsmith
reviewed
Dec 19, 2022
| @@ -17,6 +15,8 @@ export const formattedMessages = (get, applicationContext) => { | |||
| tableSort, | |||
| }); | |||
|
|
|||
| const { STATUS_TYPES } = applicationContext.getConstants(); | |||
There was a problem hiding this comment.
i like that you moved this declaration closer to its usage.
rosiehsmith
reviewed
Dec 19, 2022
# Conflicts: # web-client/src/presenter/utilities/processFormattedMessages.js
rosiehsmith
approved these changes
Dec 19, 2022
shumway-tm
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.