Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency Updates Aug 10 #2413

Merged
merged 7 commits into from
Aug 12, 2022
Merged

Dependency Updates Aug 10 #2413

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
91666e3
8-10-dep-updates: minor updates
rosiehsmith Aug 10, 2022
c64c674
8-10-dep-updates: patch updates to eslint-plugin-jsdoc, postcss, sass…
rosiehsmith Aug 10, 2022
e272d7c
8-10-dep-updates: major updates to puppeteer and puppeteer-core; mino…
rosiehsmith Aug 10, 2022
42f833c
8-10-dep-updates: minor update to react-fontawesome - icons looked fi…
rosiehsmith Aug 10, 2022
9cd83c2
8-10-dep-updates: replace soon to be deprecated faker.name.findname w…
rosiehsmith Aug 10, 2022
01df8b4
8-10-dep-updates: minor doc update
rosiehsmith Aug 10, 2022
8ce9c34
Merge branch 'staging' into 8-10-dep-updates
mmarcotte Aug 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cypress-smoketests/support/pages/trial-sessions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ exports.createTrialSession = (testData, overrides = {}) => {

cy.get('#chambers-phone-number').type(faker.phone.number());
cy.get('#trial-clerk').select(testData.trialClerk || 'Test trialclerk1');
cy.get('#court-reporter').type(faker.name.findName());
cy.get('#irs-calendar-administrator').type(faker.name.findName());
cy.get('#court-reporter').type(faker.name.fullName());
cy.get('#irs-calendar-administrator').type(faker.name.fullName());
cy.get('#notes').type(faker.company.catchPhrase());

cy.get('#submit-trial-session').click();
Expand Down
17 changes: 11 additions & 6 deletions docs/team-process.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,9 +158,14 @@ If dependencies have no patch, replace it with an alternative, or wait for the l

Below is a list of dependencies that are locked down due to known issues with security, integration problems within DAWSON, etc. Try to update these items but please be aware of the issue that's documented and ensure it's been resolved.

- `@fortawesome` packages locked down to versions pre-6.x.x to maintain consistency of icon styling until there is usability feedback and research that determines we should change them. This includes packages:
- `@fortawesome/free-solid-svg-icons`
- `@fortawesome/free-regular-svg-icons`
- `@fortawesome/fontawesome-svg-core`

- It'd be good to keep an eye on `s3rver` for when it exceeds 3.7.1. We have a patch in place for called `s3rver+3.7.1.patch` in order to address the high severity issue exposed by `s3rver`'s dependency on `busboy` 0.3.1, which relies on `dicer` that actually has the [security issue](https://github.com/advisories/GHSA-wm7h-9275-46v2). Unfortunately, `busboy` >0.3.1, aka ^1.0.0, is incompatible with s3rver which is why there's a patch in place to make it compatible.
1. `@fortawesome` packages locked down to versions pre-6.x.x to maintain consistency of icon styling until there is usability feedback and research that determines we should change them. This includes packages:
- `@fortawesome/free-solid-svg-icons`
- `@fortawesome/free-regular-svg-icons`
- `@fortawesome/fontawesome-svg-core`

2. Check if there are updates to `s3rver` above version [3.7.1](https://www.npmjs.com/package/s3rver).
- Why is there a patch called `s3rver+3.7.1.patch`?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, thanks!

- To address the high severity issue exposed by `s3rver`'s dependency on `busboy` 0.3.1, which relies on `dicer` that actually has the [security issue](https://github.com/advisories/GHSA-wm7h-9275-46v2). Unfortunately, `busboy` >0.3.1, aka ^1.0.0, is incompatible with s3rver which is why there's a patch in place to make it compatible.
- How does the patch run?
- This runs as part of the `npm postinstall` step.
- Common troubleshooting: If you see the high severity audit issue warning for `dicer`, run a full `npm install` rather than a single package update, as this will run the `postinstall` which is required to run the patch that addresses the security issue.
Loading