Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding links from assessment objectives to statement items #147

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Adding links from assessment objectives to statement items #147

merged 4 commits into from
Nov 29, 2023

Conversation

wendellpiez
Copy link
Contributor

Committer Notes

Addressing #123.

As noted on that ticket, this PR includes three (3) corrections by hand along with links generated programmatically.

At time of making this (draft) PR, some cleanup and testing remains to be done.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

@wendellpiez wendellpiez mentioned this pull request Oct 17, 2022
Closed
3 tasks
@david-waltermire david-waltermire linked an issue Oct 20, 2022 that may be closed by this pull request
Add Linking from Objectives to Statements for the 800-53 Catalog #123
Closed
3 tasks
@aj-stein-nist aj-stein-nist force-pushed the develop branch 2 times, most recently from be2fc30 to 17d7863 Compare November 2, 2022 14:20
@aj-stein-nist
Copy link
Contributor

I will hold off on this given clean up to pull such enhancements in that must happen after the 5.2 release we must coordinate upstream with the RMF Team. @wendellpiez in the interim, please rebase this PR off of current develop if you can or let me know if you need assistance later this week or early next week.

@aj-stein-nist
Copy link
Contributor

Re #174 (comment), I think this is similarly obsoleted by a parallel PR that was merged a while back, but I will circle back with @wendellpiez. I intend to close this likely tomorrow.

@aj-stein-nist aj-stein-nist self-requested a review October 24, 2023 21:02
@aj-stein-nist aj-stein-nist force-pushed the issue123-objectivelinks branch from 851c296 to 9498086 Compare October 27, 2023 20:15
@aj-stein-nist
Copy link
Contributor

I rebased the PR with Wendell today to touch it up for the current develop. After the upcoming release, we will review this PR and determine if it is feasible for release in a following release.

@Compton-US Compton-US force-pushed the issue123-objectivelinks branch from 9498086 to 108dbbd Compare November 29, 2023 15:43
@Compton-US Compton-US changed the base branch from develop to feature-800-53-updates November 29, 2023 15:45
@Compton-US Compton-US marked this pull request as ready for review November 29, 2023 15:51
@Compton-US Compton-US merged commit 3f1cd2d into usnistgov:feature-800-53-updates Nov 29, 2023
@Compton-US Compton-US mentioned this pull request Nov 29, 2023
Merged
9 tasks
Compton-US pushed a commit that referenced this pull request Dec 5, 2023
@wendellpiez @aj-stein-nist
Feature 800 53 updates (#221)
acc0d51 
* Adding links from assessment objectives to statement items (#147)

* For consistency providing link bindings, making three corrections by hand on label properties (prop[@name='label']:

- 'AC-20a.1' becomes 'AC-20a.01'
- 'AC-20a.2' becomes 'AC-20a.02'
- 'PE-03(01)02]' becomes 'PE-03(01)[02]'

* Adding enhancement XSLT with preliminary result

* Cleanup: updating content, removing preliminary result

* Correcting validation error

* Publish Updated NIST SP 800-53 Revision 5.1.1 Controls (#220)

* Update param AC-07(02)_ODP[02] to use and, not or.

* Param AC-24_ODP[01] to require only one choice.

* Add parens to param CA_02(03)_ODP[01] pluralization

* Limit param CA-08(03)_ODP[02] to 1, not >=1 select

* Change PM-31_ODP[02] and PM-31_ODP[03] param plurals

* Add control IA-13 to catalog.

* Add control enhancement IA-13.1 to catalog.

* Add control enhancement IA-13.2 to catalog.

* IA-13 control and enhancements refs must link back.

* Implementation level and assurance tag for new controls.

* Add FIPS 196 and FIPS 198-1 for IA-13.3 references to back-matter.

* Add IA-13.3, align final edits from RMF Team, and version metadata.

* Fix bad copy-paste on FIPS-196 UUID anchor for IA-13.3 refs

Re-running Schematron one last time indicated the final digit was missing from this UUID.

* Fix revisions, errant link/@rel, and resource title

* Add missing ia-13 links.

* added links for assessment objectives

* contrpl ia-13.3 error fixed

* Per reviewer's comment, replaced depends-on with related-to.

* Updated last-modified and version

* updated rel value to assessment-for per FedRAMP's request

* updated profiles' metadata

* updated profiles' root uuid

---------

Co-authored-by: Wendell Piez <wendell.piez@nist.gov>
Co-authored-by: A.J. Stein <alexander.stein@nist.gov>
Co-authored-by: Iorga <miorga@pn129618.campus.nist.gov>
Co-authored-by: Iorga <miorga@pn129618.lan>
@Compton-US Compton-US mentioned this pull request Dec 5, 2023
Merged
7 tasks
Compton-US pushed a commit that referenced this pull request Dec 5, 2023
@wendellpiez @aj-stein-nist
Feature 800 53 updates (#221) (#222)
da0e372 
* Adding links from assessment objectives to statement items (#147)

* For consistency providing link bindings, making three corrections by hand on label properties (prop[@name='label']:

- 'AC-20a.1' becomes 'AC-20a.01'
- 'AC-20a.2' becomes 'AC-20a.02'
- 'PE-03(01)02]' becomes 'PE-03(01)[02]'

* Adding enhancement XSLT with preliminary result

* Cleanup: updating content, removing preliminary result

* Correcting validation error

* Publish Updated NIST SP 800-53 Revision 5.1.1 Controls (#220)

* Update param AC-07(02)_ODP[02] to use and, not or.

* Param AC-24_ODP[01] to require only one choice.

* Add parens to param CA_02(03)_ODP[01] pluralization

* Limit param CA-08(03)_ODP[02] to 1, not >=1 select

* Change PM-31_ODP[02] and PM-31_ODP[03] param plurals

* Add control IA-13 to catalog.

* Add control enhancement IA-13.1 to catalog.

* Add control enhancement IA-13.2 to catalog.

* IA-13 control and enhancements refs must link back.

* Implementation level and assurance tag for new controls.

* Add FIPS 196 and FIPS 198-1 for IA-13.3 references to back-matter.

* Add IA-13.3, align final edits from RMF Team, and version metadata.

* Fix bad copy-paste on FIPS-196 UUID anchor for IA-13.3 refs

Re-running Schematron one last time indicated the final digit was missing from this UUID.

* Fix revisions, errant link/@rel, and resource title

* Add missing ia-13 links.

* added links for assessment objectives

* contrpl ia-13.3 error fixed

* Per reviewer's comment, replaced depends-on with related-to.

* Updated last-modified and version

* updated rel value to assessment-for per FedRAMP's request

* updated profiles' metadata

* updated profiles' root uuid

---------

Co-authored-by: Wendell Piez <wendell.piez@nist.gov>
Co-authored-by: A.J. Stein <alexander.stein@nist.gov>
Co-authored-by: Iorga <miorga@pn129618.campus.nist.gov>
Co-authored-by: Iorga <miorga@pn129618.lan>
Compton-US pushed a commit that referenced this pull request Dec 5, 2023
@wendellpiez @aj-stein-nist
Update GitHub Action HOME_REPO to point to oscal-content (#223)
002431b 
* Feature 800 53 updates (#221)

* Adding links from assessment objectives to statement items (#147)

* For consistency providing link bindings, making three corrections by hand on label properties (prop[@name='label']:

- 'AC-20a.1' becomes 'AC-20a.01'
- 'AC-20a.2' becomes 'AC-20a.02'
- 'PE-03(01)02]' becomes 'PE-03(01)[02]'

* Adding enhancement XSLT with preliminary result

* Cleanup: updating content, removing preliminary result

* Correcting validation error

* Publish Updated NIST SP 800-53 Revision 5.1.1 Controls (#220)

* Update param AC-07(02)_ODP[02] to use and, not or.

* Param AC-24_ODP[01] to require only one choice.

* Add parens to param CA_02(03)_ODP[01] pluralization

* Limit param CA-08(03)_ODP[02] to 1, not >=1 select

* Change PM-31_ODP[02] and PM-31_ODP[03] param plurals

* Add control IA-13 to catalog.

* Add control enhancement IA-13.1 to catalog.

* Add control enhancement IA-13.2 to catalog.

* IA-13 control and enhancements refs must link back.

* Implementation level and assurance tag for new controls.

* Add FIPS 196 and FIPS 198-1 for IA-13.3 references to back-matter.

* Add IA-13.3, align final edits from RMF Team, and version metadata.

* Fix bad copy-paste on FIPS-196 UUID anchor for IA-13.3 refs

Re-running Schematron one last time indicated the final digit was missing from this UUID.

* Fix revisions, errant link/@rel, and resource title

* Add missing ia-13 links.

* added links for assessment objectives

* contrpl ia-13.3 error fixed

* Per reviewer's comment, replaced depends-on with related-to.

* Updated last-modified and version

* updated rel value to assessment-for per FedRAMP's request

* updated profiles' metadata

* updated profiles' root uuid

---------

Co-authored-by: Wendell Piez <wendell.piez@nist.gov>
Co-authored-by: A.J. Stein <alexander.stein@nist.gov>
Co-authored-by: Iorga <miorga@pn129618.campus.nist.gov>
Co-authored-by: Iorga <miorga@pn129618.lan>

* Adjust home repository to oscal-content

---------

Co-authored-by: Wendell Piez <wendell.piez@nist.gov>
Co-authored-by: A.J. Stein <alexander.stein@nist.gov>
Co-authored-by: Iorga <miorga@pn129618.campus.nist.gov>
Co-authored-by: Iorga <miorga@pn129618.lan>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aj-stein-nist aj-stein-nist Awaiting requested review from aj-stein-nist

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Linking from Objectives to Statements for the 800-53 Catalog
3 participants
@wendellpiez @aj-stein-nist @Compton-US