Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update missed page with public meeting index. #1626

Merged

Conversation

aj-stein-nist
Copy link
Contributor

@aj-stein-nist aj-stein-nist commented Jan 26, 2023

Committer Notes

Update missed page with public meeting index missed in #1560.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

@aj-stein-nist aj-stein-nist requested a review from a team January 26, 2023 23:11
@aj-stein-nist aj-stein-nist self-assigned this Jan 26, 2023
Copy link
Contributor

@iMichaela iMichaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the comment left on line 35

Copy link
Contributor

@iMichaela iMichaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The information is accurate now. I wonder though if a link to the page with the meeting information (times and BJ URL) would not be appropriate here. Something lie "For more information see page ..."

@aj-stein-nist
Copy link
Contributor Author

The information is accurate now. I wonder though if a link to the page with the meeting information (times and BJ URL) would not be appropriate here. Something lie "For more information see page ..."

Let me adapt the wording and you can tell me what you think?

@aj-stein-nist aj-stein-nist force-pushed the 1560-update-meeting-list-index-page branch from 21d0702 to 6d2d442 Compare January 27, 2023 00:24
Copy link
Contributor

@nikitawootten-nist nikitawootten-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aj-stein-nist aj-stein-nist merged commit 6aae1f4 into usnistgov:main Jan 27, 2023
@aj-stein-nist aj-stein-nist deleted the 1560-update-meeting-list-index-page branch January 27, 2023 21:03
nikitawootten-nist pushed a commit that referenced this pull request Apr 10, 2023
* Update missed page with public meeting index.

* Fix PR with feedback from @iMichaela.

* Update copy with PR feedback from @iMichaela.

* Woops fix slides path for MOM 20230126.

I missed a path in merging #1627.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants