Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 12.x Compatibility #594

Merged
merged 3 commits into from
Mar 5, 2025

Conversation

laravel-shift
Copy link
Contributor

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 12.x.

Before merging, you need to:

  • Checkout the l12-compatibility branch
  • Review all comments for additional changes
  • Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

@laravel-shift
Copy link
Contributor Author

⚠️ Shift detected GitHub Actions which run jobs using a version matrix. Shift attempted to update your configuration for Laravel 12. However, you should review these changes to ensure the desired combination of versions are built for your package.

@laravel-shift
Copy link
Contributor Author

⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/tall-toasts.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "usernotnull/tall-toasts": "dev-l12-compatibility",
    }
}

Finally, run: composer update

@benjibee
Copy link

benjibee commented Mar 3, 2025

Hey @usernotnull any chance you could just take a moment and run update so this package works with Laravel 12? Please 🙏

@usernotnull
Copy link
Owner

I need volunteers to test this PR as I'm not actively maintaining this package.

@benjibee
Copy link

benjibee commented Mar 5, 2025

I need volunteers to test this PR as I'm not actively maintaining this package.

I forked this project and applied the updates from this branch. All our tests are passing and It's currently on production for about 24-hours without running into any issues.

@usernotnull usernotnull merged commit 89a5edb into usernotnull:main Mar 5, 2025
2 checks passed
@benjibee
Copy link

benjibee commented Mar 5, 2025

Thank you!

@BoGnY
Copy link

BoGnY commented Mar 6, 2025

I also used the laravel-shift fork and I didn't encounter any problems 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants