Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Nginx and PHP updates #1085

Merged
merged 5 commits into from
Apr 24, 2021
Merged

Docker Nginx and PHP updates #1085

merged 5 commits into from
Apr 24, 2021

Conversation

ssnukala
Copy link
Contributor

  1. Updated Nginx to use Pagespeed image
  2. Updated PHP configuration to use php 7.4-fpm and made related changes to the extension options
  3. Added XDebug configuration options for PHP

1. Updated nginx to use Pagespeed
2. Updated Dockerfile for app (php) to use php 7.4.-fpm and made corrosponding updates to the php extension names.
Added XDebug,
Pagespeed for Nginx Configuration
@lcharette lcharette requested review from Silic0nS0ldier and a team April 23, 2020 03:42
@codecov
Copy link

codecov bot commented Apr 24, 2021

Codecov Report

Merging #1085 (83c7b94) into hotfix (c92bf0b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             hotfix    #1085   +/-   ##
=========================================
  Coverage     67.76%   67.76%           
  Complexity     1997     1997           
=========================================
  Files           169      169           
  Lines          6995     6995           
=========================================
  Hits           4740     4740           
  Misses         2255     2255           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c92bf0b...83c7b94. Read the comment docs.

@Silic0nS0ldier
Copy link
Member

I've made some updates.

  1. Bumped NodeJS from 12.x to 14.x
  2. Updated Composer from v1 to v2 (be removing the downgrade code)
  3. Removed ngx_pagespeed citing it being a production tool and poorly supported and maintained.

Overall, this brings Docker local development up to date with our other development approaches (no idea what NodeJS version Homestead uses though...).

@Silic0nS0ldier Silic0nS0ldier merged commit bb3cf15 into userfrosting:hotfix Apr 24, 2021
@lcharette lcharette added this to the 4.5.1 milestone May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants