Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ink! release version in new contract template #1896

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

davidsemakula
Copy link
Contributor

@davidsemakula davidsemakula commented Jan 9, 2025

Summary

Closes #_ (N/A)

  • [n] y/n | Does it introduce breaking changes?
  • [n] y/n | Is it dependent on the specific version of ink or pallet-contracts?

Update Cargo.toml template used by new contract command (i.e. cargo contract new <my_contract>) to use latest crates.io version for ink and ink_e2e dependencies instead of git dependencies.

Description

Update Cargo.toml template used by new contract command (i.e. cargo contract new <my_contract>) to use latest crates.io version for ink and ink_e2e dependencies instead of git dependencies.

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have added an entry to CHANGELOG.md
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@davidsemakula davidsemakula marked this pull request as ready for review January 9, 2025 06:20
@cmichi cmichi changed the base branch from master to v5.x.x January 23, 2025 16:48
@cmichi
Copy link
Collaborator

cmichi commented Jan 23, 2025

@davidsemakula I changed the base branch to 5.x.x, the current master already contains breaking changes for 6.0.0-alpha.

Unfortunately changing the base branch messed up your whole PR 🙈 . Could you recreate it and cherry-pick the two commits?

@davidsemakula
Copy link
Contributor Author

@cmichi gotcha, on it 🙂

@davidsemakula
Copy link
Contributor Author

Done @cmichi

@cmichi cmichi merged commit 10cb226 into use-ink:v5.x.x Jan 23, 2025
9 of 11 checks passed
@davidsemakula davidsemakula deleted the new-template branch January 23, 2025 19:32
@cmichi cmichi mentioned this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants