Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use importlib not imp, better sum of weights #217

Merged
merged 1 commit into from
Sep 25, 2023
Merged

use importlib not imp, better sum of weights #217

merged 1 commit into from
Sep 25, 2023

Conversation

mmckerns
Copy link
Member

@mmckerns mmckerns commented Sep 25, 2023 •
edited
Loading

Summary

fixes #213, fixes #214

  • use importlib instead of imp.find_module
  • in python 3.12.0rc2 and earlier, a length-N list with each element of 1/N often did not sum to 1 -- so avoid the division and sum where possible.
  • update tests and examples to less frequently fail asserts.

Checklist

Documentation and Tests

  • Added relevant tests that run with python tests/__main__.py, and pass.
  • Artifacts produced with the main branch work as expected under this PR.

Release Management

  • Added "Fixes #NNN" in the PR body, referencing the issue (#NNN) it closes.
  • Added a comment to issue #NNN, linking back to this PR.
  • Added rationale for any breakage of backwards compatibility.

@mmckerns mmckerns added this to the mystic-0.4.2 milestone Sep 25, 2023
@mmckerns mmckerns changed the title fix #213 fix #214: use importlib, better weight sum use importlib not imp, better sum of weights Sep 25, 2023
@mmckerns mmckerns merged commit 84d447b into master Sep 25, 2023
@mmckerns mmckerns deleted the imp_and_sum branch September 25, 2023 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
mystic-0.4.2
Development

Successfully merging this pull request may close these issues.

AssertionErrors in tests for python 3.12 due to sum symbolic solve and simplify don't work with python 3.12
1 participant
@mmckerns