Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch SIGTERM and SIGINT #8

Merged
merged 5 commits into from
Dec 7, 2015
Merged

Catch SIGTERM and SIGINT #8

merged 5 commits into from
Dec 7, 2015

Conversation

jlevesy
Copy link
Contributor

@jlevesy jlevesy commented Dec 4, 2015

@jlevesy
Copy link
Contributor Author

jlevesy commented Dec 4, 2015

@AlexisMontagne RTM ?

AlexisMontagne
AlexisMontagne reviewed Dec 4, 2015
View reviewed changes
etcdenv/context.go
case status := <-processExitChan:
log.Println(fmt.Sprintf("Process exited with the status %d", status))

fmt.Printf("Child process exited with status %d\n", status)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not fmt.Printf but log.Printf

@jlevesy
Copy link
Contributor Author

jlevesy commented Dec 4, 2015

@AlexisMontagne RTM ?

@AlexisMontagne
Copy link
Member

LGTM

jlevesy added a commit that referenced this pull request Dec 7, 2015
@jlevesy
Merge pull request #8 from upfluence/jl-exit-codes
205b24c 
Catch SIGTERM and SIGINT
@jlevesy jlevesy merged commit 205b24c into master Dec 7, 2015
@jlevesy jlevesy deleted the jl-exit-codes branch December 7, 2015 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jlevesy @AlexisMontagne