Feature/exam admission semantic checks #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Anemone Kampkötter <anemone@kampkoetter.de>
NikoBergemann
changed the base branch from
develop
to
feature/exam_prerelease
This was
linked to
issues
Feb 17, 2021
matthias-geuchen
approved these changes
Feb 18, 2021
Comment on lines
+185
to
+188
| List<ExamAdmission> examAdmissions = this.getAllStates(stub, ExamAdmission.class); | ||
| return examAdmissions.stream().noneMatch(item -> | ||
| item.getExamId().equals(admission.getExamId()) | ||
| && item.getEnrollmentId().equals(admission.getEnrollmentId())); |
There was a problem hiding this comment.
We could just build the admission key and query for that directly, but this should of course also work.
Comment on lines
+198
to
+201
| List<CourseAdmission> courseAdmissions = this.getAllStates(stub, CourseAdmission.class); | ||
| return courseAdmissions.stream().anyMatch(item -> | ||
| item.getCourseId().equals(exam.getCourseId()) | ||
| && item.getEnrollmentId().equals(admission.getEnrollmentId())); |
Comment on lines
+96
to
+113
| if (!cUtil.checkExamExists(stub, this)) { | ||
| invalidParameters.add(cUtil.getAdmissionExamNotExistsParam()); | ||
| } | ||
| if (!cUtil.checkExamAvailableForStudent(stub, this)) { | ||
| invalidParameters.add(cUtil.getAdmissionExamNotAvailableParam("enrollmentId")); | ||
| invalidParameters.add(cUtil.getAdmissionExamNotAvailableParam("examId")); | ||
| } | ||
| if (!cUtil.checkExamAdmissionNotAlreadyExists(stub, this)) { | ||
| invalidParameters.add(cUtil.getAdmissionAlreadyExistsParam("enrollmentId")); | ||
| invalidParameters.add(cUtil.getAdmissionAlreadyExistsParam("examId")); | ||
| } | ||
| if (!cUtil.checkCourseAdmissionExists(stub, this)) { | ||
| invalidParameters.add(cUtil.getCourseAdmissionNotExistsParam("enrollmentId")); | ||
| invalidParameters.add(cUtil.getCourseAdmissionNotExistsParam("examId")); | ||
| } | ||
| if (!cUtil.checkExamAdmittable(stub, this)) { | ||
| invalidParameters.add(cUtil.getAdmissionNotPossibleParam()); | ||
| } |
There was a problem hiding this comment.
What happens for e.g. empty examId? Will we get both the error that it should not be empty, and every semantic error related to not finding the exam?
There was a problem hiding this comment.
yeah, I am not satisfied with that - imho we should only submit the exact error (only empty) but that increases the complexity. I guess we can deal with this kind of "better error management" later on, once all the functionality is established
Comment on lines
+329
to
+331
| { | ||
| "name":"admission.examId", | ||
| "reason":"The exam you are trying to admit for does not exist." |
There was a problem hiding this comment.
Guess this solves my last question....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this PR
Changes in this PR
Check, if enrollmentId is matriculated in an examinationRegulation containing the moduleId, referenced in the exam behind the examId.
Check, if enrollmentId is not admitted to the same exam already.
Check, if enrollmentId is admitted to the couseId, referenced in the exam behind the examId.
Check, if the examId is currently admittable
update tests