Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ie id enum #73

Closed
wants to merge 5 commits into from
Closed

Add ie id enum #73

wants to merge 5 commits into from

Conversation

chunmeng
Copy link
Contributor

No description provided.

@ghost
Copy link

ghost commented Jul 16, 2020

DeepCode's analysis on #f6962f found:

  • ⚠️ 1 warning 👇

Top issues

Description Example fixes
Potential nullptr dereference. 0 may return a nullptr if calloc failed to allocate memory. Consider adding a check for nullness. Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@chunmeng chunmeng closed this Jul 16, 2020
@chunmeng chunmeng deleted the add_ie_id_enum branch July 16, 2020 04:30
@chunmeng chunmeng restored the add_ie_id_enum branch July 16, 2020 04:30
@chunmeng chunmeng deleted the add_ie_id_enum branch July 16, 2020 04:31
@grrtrr
Copy link
Contributor

grrtrr commented Jul 16, 2020

Hi thank you for the PR. This looks interesting. It is a larger change so may take a couple of iterations to integrate.

I am happy to look at this later.

@alicektx
Copy link
Contributor

...was this closed by accident or something previously? :-/
The 2 extra filtering options can come up pretty handy for crowded environments,
and don't look much intrusive i'd think. Any thoughts grrtrr?

@grrtrr
Copy link
Contributor

grrtrr commented Sep 29, 2020

I didn't close this.

@alicektx alicektx mentioned this pull request Oct 3, 2020
@alicektx
Copy link
Contributor

alicektx commented Oct 3, 2020

...just noticed that 7919687 above,
assigns the 'h' shortcut for on-the-fly filtering of the 'hidden' essids:
such makes sense and is also very nice in terms of mnemonics, h for hidden,
but it appears to currently 'hijack' the current shortcut for help screen.
Not sure myself how someone should go about it eventually..

The band display filtering works pretty great though (thanks chunmeng!)
grrtrr, not really experienced with c / ncurses, some basic python skills here & there,
but i made a stripped down pull request of the band filtering feature,
in case you want to consider it for proper inclusion at some point.
I sincerely hope i'm not bothering you or wasting your time here,
and sorry in advance if such is the case...

@grrtrr
Copy link
Contributor

grrtrr commented Oct 3, 2020

@chunmeng - any comments on this?

grrtrr pushed a commit that referenced this pull request Oct 3, 2020
@grrtrr
Copy link
Contributor

grrtrr commented Oct 4, 2020

...just noticed that 7919687 above, assigns the 'h' shortcut for on-the-fly filtering of the 'hidden' essids:

That is the reason I want to shelve this for a while. The sorting keyboard shortcuts are already difficult to memorize and handle.
The above one would conflict with h, while the ones in #77 would conflict with those of #76 (which is going to be added).
To resolve these, a separate way of setting up filters / sort options for the Scan Screen is needed; likely on a different screen.

@grrtrr
Copy link
Contributor

grrtrr commented Oct 24, 2020

@chunmeng - can you please re-submit your PR or get in contact?

I want to start integrating the work that you submitted, beginning at the header for IE enums, the display of extended capabilities, and then the filter options. As @alicektx 's Pull Request shows, there is still interest in your work. Please get in contact.

@grrtrr grrtrr added the wontfix label Oct 31, 2020
grrtrr pushed a commit that referenced this pull request Oct 31, 2020
This appeared earlier as PR #73 and has been extended and documented.
grrtrr added a commit that referenced this pull request Nov 1, 2020
Scan screen: band filtering (from #73)
grrtrr pushed a commit that referenced this pull request Nov 1, 2020
Stripped out from @chunmeng's (sadly abandoned?) PR #73.
Adds scan_filter_band preference in wavemonrc, with shortcuts 0, 2, 5,
for displaying either both bands, 2.4GHz only or 5GHz accordingly.
grrtrr pushed a commit that referenced this pull request Nov 1, 2020
This appeared earlier as PR #73 and has been extended and documented.
grrtrr pushed a commit that referenced this pull request Nov 1, 2020
This adds a filter (keyboard shortcut 'h') to exclude hidden
ESSIDs from the scan window. Also taken from PR #73.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants