Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem reducing numerical values in Preferences page #66

Closed
MrEngman opened this issue Dec 18, 2019 · 5 comments
Closed

Problem reducing numerical values in Preferences page #66

MrEngman opened this issue Dec 18, 2019 · 5 comments

Comments

@MrEngman
Copy link

Found wavemon a couple of days ago and I'm trying to get used to using it but seem to have a problem.

I am using it on a Raspberry Pi. I have 2 wifi interfaces and connect to the Pi using one of the wifi interfaces and SSH. The second wifi I am trying to use in monitor mode.

My current issue is with the Preferences page. I was playing around seeing what the various settings were and changed the Statistics updates setting and it is now set at 4000ms and I am now unable to reduce is back to the original value, which I believe was 100ms.

This appears to be an issue with all the settings that use a numerical value. I can increase the value using the right arrow key but I am unable to reduce it back to its original value using the left arrow key.

Using the left and right arrow keys appear to work alright on all non-numerical setting.As an example on the interface setting if it is set to wlan0 using the right arrow key will change it to wlan1 and the left arrow key will change it back from wlan1 to wlan0.

Am I doing something stupid or is there an issue with reducing the settings that use a numeric value.

wavemon

@grrtrr
Copy link
Contributor

grrtrr commented Dec 19, 2019

Hi thanks for reporting. Very interesting problem, not reproducible on x86_64. The keys work, so it is unlikely a $TERM problem.

I suspect an untested condition that happens on 32bit. There are comparisons between int and double, that may be the clue.

If you can give me a couple of days and are able to build from master, would you be ok to test that?

@MrEngman
Copy link
Author

MrEngman commented Dec 19, 2019

Certainly can give it a go. Let me know when it's done and I'll see what I can do.

grrtrr pushed a commit that referenced this issue Dec 19, 2019
)

Boundaries and increments were expressed as double, even tough all
constants are integer values. Also avoid mixing int/char.
@grrtrr
Copy link
Contributor

grrtrr commented Dec 19, 2019

I have unified the use of variables. If the problem was caused by mixed types, this should fix it. Could you give this a try please?

@MrEngman
Copy link
Author

Looks like it is now fixed. I can change the numerical values up and now down OK.

@grrtrr
Copy link
Contributor

grrtrr commented Dec 22, 2019

Thank you very much. I will put out a new release within the next week or two.

Closing this issue now, if you run into any problems, please let me know.

@grrtrr grrtrr closed this as completed Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants