Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): add truncate and text-start #726

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

hrynevychroman
Copy link
Collaborator

πŸ”— Linked issue

Resolves #719

❓ Type of change

Added text-start to SelectTrigger, also replace line-clamp-1 by truncate, it is better to use for one line text limitation. Docs: link

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

There was a small update, as text was centered by default styles of the button HTML tag.

πŸ“Έ Screenshots (if appropriate)

image

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@sadeghbarati
Copy link
Collaborator

sadeghbarati commented Aug 22, 2024

I think the icons need the shrink-0 class

@hrynevychroman
Copy link
Collaborator Author

Yeah, 4sure, added in 3ef7ecd (#726)

@sadeghbarati sadeghbarati merged commit 85b1064 into unovue:dev Aug 22, 2024
1 check passed
@sadeghbarati sadeghbarati deleted the fix/select-truncate branch August 22, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Text in the Select component is not left-aligned when it overflows.
2 participants