Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: navBar initialization-Android & iOS #1275

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Conversation

Kunal22shah
Copy link
Contributor

@Kunal22shah Kunal22shah commented Nov 4, 2024

closes #1272
closes #1273

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@Kunal22shah Kunal22shah requested a review from kazo0 November 4, 2024 22:18
@Kunal22shah Kunal22shah self-assigned this Nov 4, 2024
Copy link

github-actions bot commented Nov 4, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1275.eastus2.azurestaticapps.net

@erikvilima
Copy link
Contributor

erikvilima commented Nov 5, 2024

Testing with the artifacts from this PR on a newly created app the NavigationBar is now rendering properly on Android. The back button is not working though (only tested on Android).

cc @Kunal22shah @kazo0 @Xiaoy312

@kazo0
Copy link
Contributor

kazo0 commented Nov 5, 2024

@Mergifyio backport release/stable/6.3

Copy link
Contributor

mergify bot commented Nov 5, 2024

backport release/stable/6.3

✅ Backports have been created

Copy link

github-actions bot commented Nov 5, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1275.eastus2.azurestaticapps.net

Copy link

github-actions bot commented Nov 5, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1275.eastus2.azurestaticapps.net

@kazo0 kazo0 merged commit 1c8aaf9 into main Nov 6, 2024
27 checks passed
@kazo0 kazo0 deleted the dev/ks/fixNavbar_Initialization branch November 6, 2024 05:46
mergify bot pushed a commit that referenced this pull request Nov 6, 2024
Co-authored-by: Steve Bilogan <steve.bilogan@gmail.com>
(cherry picked from commit 1c8aaf9)
kazo0 added a commit that referenced this pull request Nov 6, 2024
Co-authored-by: Steve Bilogan <steve.bilogan@gmail.com>
Co-authored-by: Kunal Shah <37922021+Kunal22shah@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants