feat(vswindows): Add WASDK workloads to match docs #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromelaban
approved these changes
May 29, 2023
|
We're going to have to skip this validation in the ci validations for windows: as it seems that the agents don't have the templates installed.
|
|
@jeromelaban Does this one require any additional steps from my side? |
|
Yes, we need to skip this validation in ci steps for windows, as they don't pass, and that we won't update VS on the agent to match it. |
agneszitte
approved these changes
Jun 12, 2023
jeromelaban
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Universal Windows Platform development tools represent a fairly significant dependency, which may be an obstacle to quickly getting started with Uno development.
Fortunately, the dependencies on our getting started documentation were recently updated to match the Microsoft-endorsed workloads for Windows App SDK. Accordingly, we advise new users to run the
uno-checktool to pull down the required workloads if they're missing.This PR updates our tool to no longer assume UWP workload is needed: matching the docs. It does this by using the workload ids which Microsoft details in its getting started with WASDK docs. This change is not breaking because it maintains compatibility with the previous target platform strings: "win32" and "win32desktop".