feat: dotnet new templates checkups and solution #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
reviewed
Mar 3, 2023
Comment on lines
56
to
58
| // Running 'dotnet new uninstall' without any package ID will list all installed | ||
| // dotnet new templates along with their versions. | ||
| var processInfo = new ProcessStartInfo("dotnet", "new uninstall"); |
There was a problem hiding this comment.
A more robust approach would be using Microsoft.TemplateEngine.Edge NuGet package. I haven't used it before, but I believe this is what the .NET CLI uses underneath the hoods.
That way we don't have to worry about .NET CLI changing the format of the produced output.
There was a problem hiding this comment.
Tried to use the library, but I wasn't able to get it work and there is not many useful samples for it. So for now, keeping the original approach, but if you have some resources, I would look into it further 👍
|
We need to adjust this for the new nuget package template name which is not available yet. |
Youssef1313
reviewed
Mar 10, 2023
|
DONE |
MartinZikmund
force-pushed
the
dev/mazi/update-templates
branch
from
66c8309 to
d5b9702
Compare
jeromelaban
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks for the latest version of Uno and Extensions templates and installs them if available.