Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: load config from package.json #52

Merged
merged 7 commits into from
Feb 20, 2023
Merged

Conversation

cpreston321
Copy link
Member

@cpreston321 cpreston321 commented Jan 17, 2023

Issue: #29

The only questions I have is

  1. Do we want to just normalize it to just use the name to drive how to load the package.json or do we want to support array of keys in addition of the name. The only reason I asked is unbuild supports these keys unbuild and build. Let me know what you think.

  2. If we extend from multiple directories how do we want the configFile naming convention to be ?

Thanks 💚

@pi0
Copy link
Member

pi0 commented Feb 20, 2023

Do we want to just normalize it to just use the name to drive how to load the package.json or do we want to support array of keys in addition of the name. The only reason I asked is unbuild supports these keys unbuild and build. Let me know what you think.

Good point about unbuild! We can default to name probably and either support (a more generic aliases) option or accept string|string[] for packageJson option.

@pi0 pi0 changed the title feat: load package.json config feat: load config from package.json Feb 20, 2023
@pi0 pi0 merged commit f2cc24c into unjs:main Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants