Remove redundant argument from POSIX_SOCKET_FAMILY_REGISTER macro #18
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razvand
reviewed
Aug 21, 2022
There was a problem hiding this comment.
Thanks, @mariasfiraiala
Please add an extended commit message, explaining what issue is solved by this commit (i.e. AF_INET6 registration).
mariasfiraiala
force-pushed
the
socket-fix
branch
3 times, most recently
from
4858168 to
6d4ddb6
Compare
razvand
approved these changes
Aug 21, 2022
There was a problem hiding this comment.
Thaks, @mariasfiraiala , works.
Reviewed-by: Razvan Deaconescu razvan.deaconescu@cs.pub.ro
In the `POSIX_SOCKET_FAMILY_REGISTER` macro, when the IPv6 option is selected, the third argument produces a compilation error. Due to the macro being defined in `unikraft/lib/posix-socket/include/uk/socket_driver.h` with only 2 arguments, the third argument becomes redundant. This commit removes it and ensures that the `AF_INET6` is successfully registered. Signed-off-by: Maria Sfiraiala <maria.sfiraiala@gmail.com>
mariasfiraiala
force-pushed
the
socket-fix
branch
from
6d4ddb6 to
a0cb926
Compare
marcrittinghaus
approved these changes
Aug 22, 2022
There was a problem hiding this comment.
Thanks for the patch! 🙏🏻
Good evidence of "what you didn't test, does not work". I use IPv4 99% of the time and must have forgotten to change this when updating the API.
Approved-by: Marc Rittinghaus marc.rittinghaus@kit.edu
unikraft-bot
pushed a commit
that referenced
this pull request
Aug 22, 2022
In the `POSIX_SOCKET_FAMILY_REGISTER` macro, when the IPv6 option is selected, the third argument produces a compilation error. Due to the macro being defined in `unikraft/lib/posix-socket/include/uk/socket_driver.h` with only 2 arguments, the third argument becomes redundant. This commit removes it and ensures that the `AF_INET6` is successfully registered. Signed-off-by: Maria Sfiraiala <maria.sfiraiala@gmail.com> Reviewed-by: Razvan Deaconescu <razvan.deaconescu@cs.pub.ro> Approved-by: Marc Rittinghaus <marc.rittinghaus@kit.edu> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Pull-Request: #18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Maria Sfiraiala maria.sfiraiala@gmail.com