Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified SQLite example #163

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Modified SQLite example #163

wants to merge 3 commits into from

Conversation

prasoon054
Copy link

The sqlite example previously didn't work (it had mistakes in kraftfile and an empty dockerfile). Fixed it using information from "Adding applications to the catalog" guide.

@razvand razvand requested review from StefanJum and mariapana March 13, 2025 04:36
@razvand razvand self-assigned this Mar 13, 2025
@razvand razvand added the enhancement New feature or request label Mar 13, 2025
@StefanJum
Copy link
Member

Hi @prasoon054. This was supposed to be a native build, not a bincompat build. This means no Dockerfile or base image was required.
What you did here is a completely different way than it was initially, which means I would put it in a different directory. Check the sqlite version that the docker image that you used has, and then create a new directory, library/sqlite/XX with the contents of this PR, and leave the initial directory as it is. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants