Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(library): Introduce zig 0.11.0 as library #120

Merged

Conversation

Mihnea0Firoiu
Copy link
Member

@Mihnea0Firoiu Mihnea0Firoiu commented May 10, 2024

Introduce zig 0.11.0 as library

@Mihnea0Firoiu Mihnea0Firoiu marked this pull request as draft May 10, 2024 15:47
@Mihnea0Firoiu Mihnea0Firoiu force-pushed the Mihnea0Firoiu/feat/library/zig0.11.0 branch from f5de3da to 03e5465 Compare June 17, 2024 23:07
@Mihnea0Firoiu Mihnea0Firoiu marked this pull request as ready for review June 17, 2024 23:09
Signed-off-by: Mihnea Firoiu <mihneafiroiu0@gmail.com>
@Mihnea0Firoiu Mihnea0Firoiu force-pushed the Mihnea0Firoiu/feat/library/zig0.11.0 branch from 03e5465 to d35c5bf Compare June 17, 2024 23:14
@razvand razvand requested a review from StefanJum October 14, 2024 05:00
@razvand razvand self-assigned this Oct 14, 2024
@razvand razvand added the enhancement New feature or request label Oct 14, 2024
Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Failed to mmap the phdr... error is solved by this commit.
For whatever reason doing kraft build will not pull the commit even if it's merged, but it might be some kraft cache related reason on my machine.

After that is solved there is another crash, Cannot handle write page fault at 0x1000392b30 (ec: 0x2): Bad address (14). It might have something to do with setting signal handlers, we have seen it in Java before.

@razvand
Copy link
Contributor

razvand commented Dec 19, 2024

@StefanJum , let's then have this merged as it is. There are other apps that are not working because of missing signal support (MySQL, Mongo, Java). So we can have this merged.

Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com

Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Razvan Deaconescu razvand@unikraft.io
Approved-by: Razvan Deaconescu razvand@unikraft.io

@razvand razvand merged commit ac5bb35 into unikraft:main Dec 19, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants