Move icu_plurals and icu_decimal to no_std #888
Conversation
Manishearth
requested review from
filmil,
sffc,
zbraniecki and
a team
as code owners
| @@ -80,6 +79,9 @@ impl PluralOperands { | |||
| /// Returns the number represented by this [`PluralOperands`] as floating point. | |||
| /// The precision of the number returned is up to the representation accuracy | |||
| /// of a double. | |||
| /// | |||
| /// This method requires the `"std"` feature be enabled | |||
| #[cfg(feature = "std")] | |||
There was a problem hiding this comment.
Worth highlighting: some of the math functions aren't in std
| @@ -29,6 +29,7 @@ all-features = true | |||
| ecma402_traits = { version = "0.2.0" } | |||
| icu = { path = "../../components/icu", default-features = false } | |||
| icu_provider = { version = "0.2", path = "../../provider/core" } | |||
| icu_plurals = { version = "0.2", path = "../../components/plurals", features = ["std"] } | |||
There was a problem hiding this comment.
I had to add this because ecma402_traits requires error types to implement Error
There was a problem hiding this comment.
Filed google/rust_icu#207
Manishearth
changed the title
Codecov Report
@@ Coverage Diff @@
## main #888 +/- ##
==========================================
+ Coverage 74.27% 74.36% +0.09%
==========================================
Files 211 206 -5
Lines 13129 13058 -71
==========================================
- Hits 9751 9711 -40
+ Misses 3378 3347 -31
Continue to review full report at Codecov.
|
Pull Request Test Coverage Report for Build 1d1bebc8176995db31b9e75b1eaed997264901cd-PR-888
💛 - Coveralls |
There's been discussion about the math functions being a part of std in the past; the contention is that baremetal targets may wish to plug in their own. We could include a no_std manual |
Progress towards #812