Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move locale_canonicalizer and StaticDataProvider to no_std, use SDP correctly in capi #880

Merged
merged 6 commits into from
Jul 22, 2021

Conversation

Manishearth
Copy link
Member

Progress towards #812

Also makes the capi crate pull in the Fs/Static data providers more strategically.

@Manishearth Manishearth requested review from sffc and a team as code owners July 21, 2021 22:27
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2021

Codecov Report

Merging #880 (e5d7a2a) into main (6a7650e) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #880      +/-   ##
==========================================
+ Coverage   74.27%   74.36%   +0.08%     
==========================================
  Files         211      206       -5     
  Lines       13129    13058      -71     
==========================================
- Hits         9752     9711      -41     
+ Misses       3377     3347      -30     
Impacted Files Coverage Δ
components/locale_canonicalizer/src/lib.rs 100.00% <ø> (ø)
...s/locale_canonicalizer/src/locale_canonicalizer.rs 76.29% <ø> (ø)
components/locale_canonicalizer/src/provider.rs 8.00% <ø> (ø)
ffi/capi/src/provider.rs 0.00% <ø> (ø)
experimental/provider_ppucd/src/parse_ppucd.rs 92.99% <0.00%> (-0.14%) ⬇️
provider/testdata/src/metadata.rs
provider/testdata/src/blob.rs
provider/testdata/src/paths.rs
provider/testdata/src/fs.rs

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a7650e...e5d7a2a. Read the comment docs.

@coveralls
Copy link

coveralls commented Jul 21, 2021

Pull Request Test Coverage Report for Build 66e51ec49b9651a302564b9c98c9e0ec9b34098f-PR-880

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.008%) to 74.431%

Files with Coverage Reduction New Missed Lines %
experimental/provider_ppucd/src/parse_ppucd.rs 1 93.0%
Totals Coverage Status
Change from base Build 6a7650eef7b24d2ac7f539d7b1d86249d036e316: -0.008%
Covered Lines: 9842
Relevant Lines: 13223

💛 - Coveralls

sffc
sffc previously approved these changes Jul 21, 2021
@Manishearth Manishearth merged commit 77e8269 into unicode-org:main Jul 22, 2021
@Manishearth Manishearth deleted the lc-nostd branch July 22, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants