Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move locid and fixed_decimal over to no_std #868

Merged
merged 4 commits into from
Jul 21, 2021

Conversation

Manishearth
Copy link
Member

Progress towards #812

@Manishearth Manishearth requested review from nciric, sffc, zbraniecki and a team as code owners July 20, 2021 22:59
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • components/locid/src/serde/langid.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

sffc
sffc previously approved these changes Jul 20, 2021
@@ -45,6 +45,7 @@ path = "src/lib.rs"

[features]
default = []
std = ["displaydoc/std"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: what does "displaydoc/std" do and why do you need it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't actually need it, I can remove this bit.

@coveralls
Copy link

coveralls commented Jul 20, 2021

Pull Request Test Coverage Report for Build fe07af334605a1e241e6cfd5aaf63599a654061a-PR-868

  • 32 of 36 (88.89%) changed or added relevant lines in 11 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 74.369%

Changes Missing Coverage Covered Lines Changed/Added Lines %
components/locid/src/extensions/mod.rs 1 2 50.0%
components/locid/src/helpers.rs 9 10 90.0%
components/locid/src/locale.rs 2 3 66.67%
components/locid/src/serde/langid.rs 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
utils/fixed_decimal/src/decimal.rs 1 94.68%
Totals Coverage Status
Change from base Build e5f7a5e5c737ee6e3ba0c53e789d131d3eb277a8: 0.0%
Covered Lines: 9819
Relevant Lines: 13203

💛 - Coveralls

@codecov-commenter
Copy link

Codecov Report

Merging #868 (aec13f6) into main (e5f7a5e) will not change coverage.
The diff coverage is 88.88%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #868   +/-   ##
=======================================
  Coverage   74.30%   74.30%           
=======================================
  Files         206      206           
  Lines       13038    13038           
=======================================
  Hits         9688     9688           
  Misses       3350     3350           
Impacted Files Coverage Δ
components/locid/src/extensions/private/key.rs 88.23% <ø> (ø)
...omponents/locid/src/extensions/transform/fields.rs 83.33% <ø> (ø)
components/locid/src/extensions/transform/key.rs 88.88% <ø> (ø)
components/locid/src/extensions/transform/value.rs 88.57% <ø> (ø)
...mponents/locid/src/extensions/unicode/attribute.rs 85.00% <ø> (ø)
...ponents/locid/src/extensions/unicode/attributes.rs 83.33% <ø> (ø)
components/locid/src/extensions/unicode/key.rs 91.30% <ø> (ø)
...omponents/locid/src/extensions/unicode/keywords.rs 81.48% <ø> (ø)
components/locid/src/extensions/unicode/value.rs 90.62% <ø> (ø)
components/locid/src/lib.rs 100.00% <ø> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5f7a5e...aec13f6. Read the comment docs.

@Manishearth Manishearth merged commit ff56a70 into unicode-org:main Jul 21, 2021
@Manishearth Manishearth deleted the locid-nostd branch July 21, 2021 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants