Progress towards no_std #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
requested review from
echeran,
filmil,
nciric,
sffc,
zbraniecki and
a team
as code owners
Codecov Report
@@ Coverage Diff @@
## main #865 +/- ##
==========================================
+ Coverage 74.35% 74.37% +0.01%
==========================================
Files 206 206
Lines 13042 13032 -10
==========================================
- Hits 9697 9692 -5
+ Misses 3345 3340 -5
Continue to review full report at Codecov.
|
Pull Request Test Coverage Report for Build 2fdce6248056fa6a7326998b4f61fe45ec4ad2f9-PR-865
💛 - Coveralls |
Manishearth
commented
Jul 19, 2021
.cargo/config.toml
Outdated
| @@ -13,6 +13,8 @@ tidy = "make tidy" | |||
| # field-reassign-with-default: https://github.com/rust-lang/rust-clippy/issues/6559 (fixed in nightly but not stable) | |||
| clippy-all = "clippy --all-features --all-targets -- -D warnings -Aclippy::field-reassign-with-default" | |||
|
|
|||
| check-thumb = "check --target thumbv7m-none-eabi" | |||
There was a problem hiding this comment.
I can remove these if necessary
There was a problem hiding this comment.
Request: Add a comment for what these are for
sffc
reviewed
Jul 19, 2021
.cargo/config.toml
Outdated
| @@ -13,6 +13,8 @@ tidy = "make tidy" | |||
| # field-reassign-with-default: https://github.com/rust-lang/rust-clippy/issues/6559 (fixed in nightly but not stable) | |||
| clippy-all = "clippy --all-features --all-targets -- -D warnings -Aclippy::field-reassign-with-default" | |||
|
|
|||
| check-thumb = "check --target thumbv7m-none-eabi" | |||
There was a problem hiding this comment.
Request: Add a comment for what these are for
| @@ -2,6 +2,8 @@ | |||
| // called LICENSE at the top level of the ICU4X source tree | |||
| // (online at: https://github.com/unicode-org/icu4x/blob/main/LICENSE ). | |||
|
|
|||
| #![cfg_attr(not(test), no_std)] | |||
There was a problem hiding this comment.
Request: Make this more consistent between writeable and yoke
sffc
previously approved these changes
Jul 19, 2021
sffc
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress towards #812
This contains some progress towards
no_stdsupport. The main accomplishments of this PR are:no_stdcompatible nowserdeis built withno_stdunless otherwise necessary.This should not regress any behavior, and should generally be desirable for these crates anyway. We do not use any of serde's std features, so we do not need to pull it in with std. Rust unifies features so if icu4x is used by a crate that does need serde-with-std, it will pull in the appropriate dependency as needed.
There is nothing to test as a result of this PR since we do not yet have a complete
icu_capino_stdbuild.Making a PR now because this work bitrots really easily.