Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move icu_uniset into collections component as codepointinvlist module #2328

Merged
merged 7 commits into from
Aug 3, 2022

Conversation

echeran
Copy link
Contributor

@echeran echeran commented Aug 3, 2022

Part 2/3 of #1856

  • Moving util crate icu_uniset into component crate icu_collections as module (re)named as codepointtrieinvlist

@echeran echeran removed request for a team, robertbastian and hsivonen August 3, 2022 17:57
Manishearth
Manishearth previously approved these changes Aug 3, 2022
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is still broken (and there are conflicts)

Manishearth
Manishearth previously approved these changes Aug 3, 2022
@echeran
Copy link
Contributor Author

echeran commented Aug 3, 2022

CI is still broken (and there are conflicts)

Fyi @QnnOkabayashi

@Manishearth Yep. There were some benchmarks and examples that needing more explicit configuration. When they were under their own respective crates, they would still get auto-detected because they were in the benches and examples folder at the root of the create, which is the default location that Cargo checks. The benchmark programs used by performance benchmarks and the example programs used by the memory benchmarks look for them.

Do you have an opinion on the current organization of code? Should all the benches code be put together in the same folder at the root of the icu_collections crate, or should they be separate and alongside their respective data structure's module within the crate?

@Manishearth
Copy link
Member

@echeran Rust strongly prefers benches at crate root.

For all intents and purposes this should just be a normal Rust crate with a couple datastructures in it.

Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm except that we should probably move the benches to the top level at some point

@echeran
Copy link
Contributor Author

echeran commented Sep 23, 2022

lgtm except that we should probably move the benches to the top level at some point

Agreed. We have #2342 to track.

@echeran echeran deleted the cpinvlist-to-collections branch June 8, 2023 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants