-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move icu_uniset into collections component as codepointinvlist module #2328
Move icu_uniset into collections component as codepointinvlist module #2328
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is still broken (and there are conflicts)
Fyi @QnnOkabayashi @Manishearth Yep. There were some benchmarks and examples that needing more explicit configuration. When they were under their own respective crates, they would still get auto-detected because they were in the Do you have an opinion on the current organization of code? Should all the |
@echeran Rust strongly prefers benches at crate root. For all intents and purposes this should just be a normal Rust crate with a couple datastructures in it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm except that we should probably move the benches to the top level at some point
Agreed. We have #2342 to track. |
Part 2/3 of #1856
icu_uniset
into component crateicu_collections
as module (re)named ascodepointtrieinvlist