Post 0.6 release fixes #1895
Post 0.6 release fixes #1895
Conversation
dminor
requested review from
a team,
sffc,
robertbastian,
Manishearth,
aethanyc and
makotokato
as code owners
docs/process/release.md
Outdated
| @@ -16,15 +16,20 @@ Once the release is complete, the assigned release driver will: | |||
| * Documentation | |||
| * Coverage | |||
| * Performance / Memory / Size benchmarks | |||
| * Cargo.toml files | |||
| * Cargo.toml files need to specify versions for each dependency. | |||
There was a problem hiding this comment.
Suggestion: we could exclude dev-dependencies here
There was a problem hiding this comment.
From what @sffc has said, we should explicitly not use versions for dev-dependencies because that will avoid the problem with having to edit Cargo.toml files to break dependency cycles, so I'll adjust the text here to reflect that.
| include = ["src/**/*.rs", "Cargo.toml"] | ||
| repository = "https://github.com/unicode-org/icu4x" | ||
| license-file = "LICENSE" | ||
| categories = ["internationalization"] |
There was a problem hiding this comment.
Hmm I didn't realize that we'd have to publish this on its own if we make it a separate crate, and I don't think we should do that. Maybe we can include its files in icu_testdata directly. Or is there some way to have unlisted crates on crates.io? @sffc wdyt?
There was a problem hiding this comment.
I think at the bare minimum it should be called icu_baked_testdata or something
But I'd prefer to not publish it too.
There was a problem hiding this comment.
I'll rename it here. I agree, we shouldn't publish it separately, but that's a larger change.
| include = ["src/**/*.rs", "Cargo.toml"] | ||
| repository = "https://github.com/unicode-org/icu4x" | ||
| license-file = "LICENSE" | ||
| categories = ["internationalization"] |
There was a problem hiding this comment.
I think at the bare minimum it should be called icu_baked_testdata or something
But I'd prefer to not publish it too.
Whichever way you prefer is fine for me :) |
|
Merged |
dminor
force-pushed
the
post-0.6-release-fixes
branch
from
fa6e3fe to
f924862
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
This updates missing data in the Cargo.toml files, adds to the release.md file and updates intro.md.
The datetime example in intro.md results in a compiler panic, I will file a separate issue for that.